Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🧑‍🌾 rosidl_adapter mypy test regression timeout in Windows #835

Open
Crola1702 opened this issue Nov 6, 2024 · 3 comments
Open

Comments

@Crola1702
Copy link

Bug report

Required Info:

  • Operating System:
    • Windows
  • Installation type:
    • Source
  • Version or commit hash:
    • Rolling

Steps to reproduce issue

  1. Run a build in windows debug
  2. See rclpy.test_node.xunit.missing_result test regression

Additional information

Reference build:

Test regression:

test 2
    Start 2: mypy

2: Test command: C:\Python38\python_d.exe "-u" "C:/ci/ws/install/share/ament_cmake_test/cmake/run_test.py" "C:/ci/ws/build/rosidl_adapter/test_results/rosidl_adapter/mypy.xunit.xml" "--package-name" "rosidl_adapter" "--output-file" "C:/ci/ws/build/rosidl_adapter/ament_mypy/mypy.txt" "--command" "C:/ci/ws/install/Scripts/ament_mypy.exe" "--xunit-file" "C:/ci/ws/build/rosidl_adapter/test_results/rosidl_adapter/mypy.xunit.xml"
2: Working Directory: C:/ci/ws/src/ros2/rosidl/rosidl_adapter
2: Test timeout computed to be: 60
2: -- run_test.py: invoking following command in 'C:\ci\ws\src\ros2\rosidl\rosidl_adapter':
2:  - C:/ci/ws/install/Scripts/ament_mypy.exe --xunit-file C:/ci/ws/build/rosidl_adapter/test_results/rosidl_adapter/mypy.xunit.xml
1/1 Test #2: mypy .............................***Timeout  60.21 sec

Probably caused by #828

@InvincibleRMC
Copy link
Contributor

InvincibleRMC commented Nov 7, 2024

Hmm I wonder why mypy times out when running Windows debug but not the other Windows builds.

Running mypy locally on my Windows machine only takes 5.2 seconds.

Output from Measure-Command {mypy .}

Days              : 0
Hours             : 0
Minutes           : 0
Seconds           : 5
Milliseconds      : 258
Ticks             : 52583442
TotalDays         : 6.08604652777778E-05
TotalHours        : 0.00146065116666667
TotalMinutes      : 0.08763907
TotalSeconds      : 5.2583442
TotalMilliseconds : 5258.3442

@InvincibleRMC
Copy link
Contributor

For resolving this issue would it be better to revert #828 or just remove the failing mypy test since the types added can still be useful?

@Crola1702
Copy link
Author

Tagging @sloretz as PR approver

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants