Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Text selection is unreadable #1

Closed
pansy27 opened this issue Jan 27, 2022 · 3 comments
Closed

Text selection is unreadable #1

pansy27 opened this issue Jan 27, 2022 · 3 comments

Comments

@pansy27
Copy link

pansy27 commented Jan 27, 2022

Hello.

I was trying out rose pine themes for helix text editor when i found out that "Text highlight background color" for both of these themes is the same as normal background color of the theme which makes it impossible to look at the highlight text as it appears as a solid color block. Here are some screenshots of the problem i am facing:

Rose pine dawn :

21_56_25

Rose pine :

21_56_41

Base 16 default dark for comparison:

21_56_59

Base 16 default light:

22_ 1_03

In all of the screenshots i am selecting the same text, from line 71 to line 81.

I tried all of these themes on a clean install of helix. I have made no changes whatsoever to the highlight part of the text editor.

@mvllow
Copy link
Member

mvllow commented Jan 27, 2022

We noticed that too 😔 Unfortunately we didn't make these themes but we do love helix so will look into getting that updated! 

@mvllow mvllow changed the title Text highlight background color broken for both Rose Pine and Rose Pine Dawn theme for Helix Text Editor. Text selection is unreadable Jan 27, 2022
@pansy27
Copy link
Author

pansy27 commented Jan 27, 2022

I see. Thank you for looking into this.

@mvllow
Copy link
Member

mvllow commented May 1, 2022

Looks like this was fixed in helix-editor/helix#1716 🎉

@mvllow mvllow closed this as completed May 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants