Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: Add support for epwalsh/obsidian.nvim #322

Open
anupam-basu opened this issue Oct 20, 2024 · 1 comment
Open

feature: Add support for epwalsh/obsidian.nvim #322

anupam-basu opened this issue Oct 20, 2024 · 1 comment

Comments

@anupam-basu
Copy link

Describe the solution you'd like

In the Dawn theme reading bullet points, checkboxes and links/reference texts are but too light on my eyes. Here are some screenshots
Screenshot 2024-10-20 at 9 23 08 AM
Screenshot 2024-10-20 at 9 23 18 AM
Screenshot 2024-10-20 at 9 24 06 AM

Hoping for some more stark highlights than the current one.

Additional context

I've been using epwalsh/obsidian.nvim
and modified the setup to have more agreeable colors to my eyes, but I was hoping the default can be changed or updated.

    require("obsidian").setup({
      ui = {
        hl_groups = {
          ObsidianBullet = { fg = "#b4637a" },
          ObsidianRefText = { underline = true, fg = "#286983" },
        },
      },...

These colors I thought were better, if there are any other suggestions for them, more than happy to accept !

@mvllow
Copy link
Member

mvllow commented Oct 20, 2024

Ah those aren't Rosé Pine colours so we need to add support for that plugin. If you want to submit a PR with your preferred changes (ideally we would theme all colours for that plugin) that would be appreciated :) For simplicity we could match the checkbox unchecked to our gold, checked to our foam and their purple in the "Done List" example to be our iris.

A good way to test this locally would be:

require("rose-pine").setup({
  -- Accepts highlight names from rosepinetheme.com/palette
  highlight_groups = {
    ObsidianBullet = { fg = "muted" },
    ObsidianRefText = { fg = "iris", underline = true },
  }
})

@mvllow mvllow changed the title feature: Some highlight improvements for markdown on the dawn theme feature: Add support for epwalsh/obsidian.nvim Oct 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants