Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run query from selection / from document #8

Open
rosshamish opened this issue Jul 26, 2019 · 3 comments
Open

Run query from selection / from document #8

rosshamish opened this issue Jul 26, 2019 · 3 comments
Labels
feature New feature or request

Comments

@rosshamish
Copy link
Owner

We don't want to dupe functionality from Kusto Explorer / Kusto Web Explorer though, so probably the best route here is to generate a link to kusto web explorer with the query text url encoded, then use open() to open it in the browser. Shell out to web explorer, which already implements all this. Folks can bounce back and forth between the web explorer (for execution) and vs code (for source control).

Best part of this would be that the web explorer and vs code's editor capabilities are based on the same npm module(s), so the editing experience should/would be exactly the same. Consistency!

@rosshamish rosshamish changed the title Feature: run query from selection / from document Run query from selection / from document Jul 26, 2019
@rosshamish rosshamish added the feature New feature or request label Jul 26, 2019
@stevenhurwitt
Copy link
Contributor

Why do you not want to duplicate functionality here? Personally I've been looking for a way to query Kusto Explorer from either Visual Studio or Visual Studio Code - since I can also query SQL Server from both of these. I think it'd be really cool to extend the Language Server you've already made into a view of databases/tables and a way to execute queries from .kql scripts. Something like https://github.com/Microsoft/vscode-mssql. Might look into this but I'm not too knowledgeable on the matter...

@rosshamish
Copy link
Owner Author

The motivation for not duplicating functionality was to avoid duplicating the work. For our use case (the group of us that originally worked on this), we were totally content with using kusto's web explorer as the execution environment.

However, as I mentioned in my reply to #26, if you're interested in extending this project to support an execution environment, you're more than welcome. Probably the best route would be to work in your fork, and periodically send PRs back here, and we can work together on reviewing/testing and then publishing the changes to the extension store. I don't check github notifications much but I do check email, so feel free to send me a line there.

@stevenhurwitt
Copy link
Contributor

thanks, sounds good man!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants