DateTime?

[aaronchi]

This library is great but is there any way to make it work with datetimes instead of just dates?

[rossmeissl]

Hi @aaronchi, certainly that's possible. We use the timeframe library in our CM1 web service, where everything is quantized down to the day level, so there's really no need for time. If you wanted to fork and get things running with DateTime I'd love to accept a pull request for this.

cc @seamusabshere

[seamusabshere]

hey @aaronchi if you don't feel confident about a pull request you could also write tests / give a good description of how the functionality would change with DateTime.

cc @rossmeissl

[aaronchi]

Thanks guys. I just copied the lib into my project and started making some adjustments to see if it would work. For the most part, it seems to be working just by changing the from and to variables to a time object instead of a date object.

I'm not sure how this change would affect your use of the library, if there needs to be an option to set the range as a date or a time or if using times would work across the board. I'm going to continue to modify this just for my purposes and I may try a push later when I can write some proper specs.

[rossmeissl]

@aaronchi -- any progress? If not, shall I close this issue?

[rossmeissl]

@aaronchi -- ping