Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OSX build failure #3

Open
phoe opened this issue Jan 30, 2022 · 6 comments
Open

OSX build failure #3

phoe opened this issue Jan 30, 2022 · 6 comments

Comments

@phoe
Copy link
Collaborator

phoe commented Jan 30, 2022

I tried to follow the manual, but there's a OSX failure of some sort that prevents me from making a OSX release.

Tag: https://github.com/roswell/clisp_head/actions/runs/1768812750
Linux: https://github.com/roswell/clisp_head/actions/runs/1768819106
OSX: https://github.com/roswell/clisp_head/runs/4997039566?check_suite_focus=true

@snmsts
Copy link
Member

snmsts commented Jan 30, 2022

{"message":"API rate limit exceeded for 199.7.166.17. (But here's the good news: Authenticated requests get a higher rate limit. Check out the documentation for more details.)","documentation_url":"https://docs.github.com/rest/overview/resources-in-the-rest-api#rate-limiting"}

It seems it built right. Only problem it has is the osx instance assigned for build doesn't have right to upload for now.
Nothing wrong with ci setting. and ci will be triggered and it will be ok tomorrow or day after tomorrow or so on... or you can try again...

@phoe
Copy link
Collaborator Author

phoe commented Jan 30, 2022

OK - I'll wait for a scheduled build and I'll update the TSV only once OSX succeeds to upload.

@snmsts
Copy link
Member

snmsts commented Jan 30, 2022

You may decide when to trigger but I think clisp_head is experimental in any sense. so version gap between some architectures wouldn't introduce issue so it would be ok to trigger TSV now and trigger again tomorrow after it updates would be also no problem.
Thanks.

@phoe
Copy link
Collaborator Author

phoe commented Jan 31, 2022

I still can't do that today.

Only problem it has is the osx instance assigned for build doesn't have right to upload for now.

According to https://docs.github.com/en/actions/security-guides/automatic-token-authentication#using-the-github_token-in-a-workflow it should have to do so. The value secrets.GITHUB_TOKEN is mentioned multiple times in https://github.com/roswell/clisp_head/blob/main/.github/workflows/osx.yml and yet it complains about the request being unauthenticated.

https://github.com/roswell/clisp_bin/blob/b4368f1f455447e9eefd0500a3247b84a7490194/Makefile#L96-L97 mentions a script called web.ros that performs the uploading and it seems it is downloaded via https://github.com/roswell/clisp_bin/blob/b4368f1f455447e9eefd0500a3247b84a7490194/Makefile#L47-L48 from https://raw.githubusercontent.com/roswell/sbcl_head/master/web.ros and this file mentions a symbol named roswell.github.utils:github that I cannot find defined anywhere on GitHub.

@snmsts
Copy link
Member

snmsts commented Feb 3, 2022

Can't you find?
https://github.com/search?q=roswell.github.utils&type=code

If the success/failure rate is super low... I might want to care more but It seems success in a week.
I already accept this rate. I try to believe no one use osx/intel already. :)

@phoe
Copy link
Collaborator Author

phoe commented Feb 3, 2022

Nice! For some reason I couldn't find this library earlier, thank you. :D

OK, if it succeeds once a week then I guess it's good enough for practical purposes. The issue could stay open if anyone actually wants to dive into the build and figure out what goes wrong.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants