Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add hint and explanation to questions #472

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

tunny17
Copy link
Collaborator

@tunny17 tunny17 commented Sep 11, 2024

What does this PR do?

Fixes #469

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Chore (refactoring code, technical debt, workflow improvements)
  • Enhancement (small improvements)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change adds a new database migration
  • This change requires a documentation update

How should this be tested?

  • Create an exercise and add questions with hints or explanations

Checklist

Required

  • Filled out the "How to test" section in this PR
  • Self-reviewed my own code
  • Commented on my code in hard-to-understand bits
  • Ran pnpm build
  • Checked for warnings, there are none
  • Removed all console.logs
  • Merged the latest changes from main onto my branch with git pull origin main
  • My changes don't cause any responsiveness issues

Appreciated

Copy link

github-actions bot commented Sep 11, 2024

Thank you for following the naming conventions for pull request titles! 🙏

Copy link
Collaborator

@rotimi-best rotimi-best left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tunny17 Please let me know the response to my comments

@@ -94,6 +94,7 @@

<RoleBasedSecurity allowedRoles={[1, 2]}>
<ContentSwitcher bind:selectedIndex class="mb-2">
<!-- come back here, the numbering is buggy -->
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tunny17 What does this mean?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed when i was adding and deleting the questions on edit mode, the numbering was wrong at some point like it wasn't getting the live update of the number of questions present

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tunny17 Please share a video of how this works.

Comment on lines +25 to +26
hint: '',
explanation: '',
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the difference between hint and explanation?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you said the users should have a hint then after they get the question right, "if" the question has an explanation, the explanation should then show before moving to the next question.
"Show a correct answer hint in the answers. That is, after they selected the answer, they get a message explaining the answer further."

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tunny17 Okay a miscommunication on my end. The hint wasn't something I had initially thought about, I just meant that the teacher enters an explanation to the question and at when the students get the question we then show them the explanation before moving to the next question

However I am curious how you implemented this hint, please share a video

Copy link

vercel bot commented Sep 16, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
cio-com ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 18, 2024 10:44am
cio-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 18, 2024 10:44am

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Correct answer hint
2 participants