-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add hint and explanation to questions #472
base: main
Are you sure you want to change the base?
Conversation
Thank you for following the naming conventions for pull request titles! 🙏 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tunny17 Please let me know the response to my comments
@@ -94,6 +94,7 @@ | |||
|
|||
<RoleBasedSecurity allowedRoles={[1, 2]}> | |||
<ContentSwitcher bind:selectedIndex class="mb-2"> | |||
<!-- come back here, the numbering is buggy --> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tunny17 What does this mean?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I noticed when i was adding and deleting the questions on edit mode, the numbering was wrong at some point like it wasn't getting the live update of the number of questions present
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tunny17 Please share a video of how this works.
hint: '', | ||
explanation: '', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's the difference between hint and explanation?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you said the users should have a hint then after they get the question right, "if" the question has an explanation, the explanation should then show before moving to the next question.
"Show a correct answer hint in the answers. That is, after they selected the answer, they get a message explaining the answer further."
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tunny17 Okay a miscommunication on my end. The hint wasn't something I had initially thought about, I just meant that the teacher enters an explanation to the question and at when the students get the question we then show them the explanation before moving to the next question
However I am curious how you implemented this hint, please share a video
apps/dashboard/src/lib/components/QuestionContainer/index.svelte
Outdated
Show resolved
Hide resolved
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
What does this PR do?
Fixes #469
Type of change
How should this be tested?
Checklist
Required
pnpm build
console.logs
git pull origin main
Appreciated
https://www.loom.com/share/aabe9d2465214efcbf4b54d19b114204?sid=645a6efc-f3d4-463b-bd43-99d27be0a1c3