Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

System.err in PdfBoxGraphics2DFontTextDrawer #49

Closed
pmds-martins opened this issue May 11, 2023 · 8 comments
Closed

System.err in PdfBoxGraphics2DFontTextDrawer #49

pmds-martins opened this issue May 11, 2023 · 8 comments

Comments

@pmds-martins
Copy link
Contributor

Hello, my name is Pedro Martins and I'm here to report what I think is a bug.

I noticed that in the PdfBoxGraphics2DFontTextDrawer class of the de.rototor.pdfbox.graphics2d package, an error is being printed using System.err instead of creating an error entry through a logger.

Here is the line of code:

System.err.println("PDFBoxGraphics: Can not map text " + text + " with font "

@rototor
Copy link
Owner

rototor commented May 11, 2023

Well this tells the developer why he won't see a text at all. Using SL4J would be nicer here, but I won't pull in this dependency without any pressing need. I see no reason to suppress this error.

@rototor rototor closed this as completed May 11, 2023
@pmds-martins
Copy link
Contributor Author

Hello rototor,

You don't need to use SL4J, you can use a Logger from java logging framework.
Actually it's very important for me to have a logger when this exception is thrown.

Best regards

@rototor
Copy link
Owner

rototor commented May 15, 2023

I wont have time for that in the near future. But feel free to provide a PullRequest.

@rototor rototor reopened this May 15, 2023
@pmds-martins
Copy link
Contributor Author

Pull request created: #50

@rototor
Copy link
Owner

rototor commented May 15, 2023

I assume you need a new released version soon?

@pmds-martins
Copy link
Contributor Author

Yes :)

@rototor
Copy link
Owner

rototor commented May 16, 2023

I've just released version 0.43. Should show up very soon on maven central.

@rototor rototor closed this as completed May 16, 2023
@rototor
Copy link
Owner

rototor commented May 16, 2023

There seems to be some issues with the sonatype repository. I did the release:perform and all seemed to work. I also got a Lift Review but it did at least for now not yet show up in maven central.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants