Optional config for roundcube

[freman]

Hey, so at the moment the only way to tweak roundcube config (say to add config for a plugin) is to replace a config file, I'd like to propose the following change

mkdir config/config.inc.d/
mv config/config.docker.inc.php config/config.inc.d/

replace the include line from config.inc.d to

foreach (glob("config.inc.d/*.php") as $filename)
{
    include $filename;
}

We could mount various configs into that dir.

alternatively just have config.docker.inc.php check for a user include mounted into that dir and include that...

[thomascube]

For additional config files we have the /var/roundcube/config volume which is loaded pretty much the same way you propose here except that the for loop is done in the docker-entrypoint and not in PHP:
https://github.com/roundcube/roundcubemail-docker/blob/master/apache/docker-entrypoint.sh#L153-L156

I don't see the benefit of the way you propose to what we already have. Please clarify if I seem to miss something here.

[HanSyt]

I was struggling with docker and plugins, especially the authres_status plugin. When using the env plugin settings, the container kept crashing. So I made 2 volumes: /var/www/html/config en /plugins. (roundcube_config resp roundcube_plugins)
I commented out the include config docker inc and did the whole config in config_inc.php, pretty like a standalone roundcube installation.
This is not what you ment I guess, but makes the system more flexible for me (and the plugin did not crash).