Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Invalid packaging #525

Open
benmccann opened this issue Aug 22, 2023 · 2 comments
Open

Invalid packaging #525

benmccann opened this issue Aug 22, 2023 · 2 comments
Labels
bug Something isn't working

Comments

@benmccann
Copy link
Contributor

Describe the bug

v2 and v3 both have invalid packaging. I was helping a user try to get jest tests running under ESM with Routify and it seems not to be working because of the packaging issues

Reproduction

https://publint.dev/@roxi/routify@2.18.12
https://publint.dev/@roxi/routify@3.0.0-next.178

Logs

No response

System Info

Routify 2.18.12
Routify 3.0.0-next.178
@benmccann benmccann added bug Something isn't working needs triage labels Aug 22, 2023
@benmccann benmccann mentioned this issue Aug 22, 2023
Merged
@jakobrosenberg
Copy link
Member

Hi Ben! Thanks for the heads up and PR. Do you know if your PR fixes the issue?

@benmccann
Copy link
Contributor Author

It fixed a lot of the issues on the v3 branch. One remains though: https://publint.dev/@roxi/routify@3.0.0-next.179

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@benmccann @jakobrosenberg @ghostdevv