-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Output desired size when AD container size is exceeded #84
Comments
does metaphysicl allow verbose error messages? |
We don't have a macro for it, but we ought to add one. |
I'm not sure it's going to be possible to tell users which size to resize to. We hit that error and exit the first time we try to resize to anything larger than the current size, so we won't keep going to find out what the final required size is going to be. Add an ADReal with (dense, to simplify the example) gradient indices of [0,20) to a vector with indices of [15,35) and if your max sparse vector size is 30 the program is going to bail there and tell you needed 35, not wait around to find out that your code was later going to add a third vector with indices of [30,50) and a fourth with [45,65). I almost said "can't" rather than "won't" keep going, because I'm wondering if there's anything we can do here to actually keep going until we're done. Looking at DualReal.h, for one thing we really ought to have a |
Especially given the recent timings in libMesh#29 I think it definitely makes sense to have |
it could be part of our MOOSE makefile. When you include a module that needs a high number, we ask you to reconfigure? |
Maybe but that is a pain for folks not using the AD portions of applications |
It would be convenient to tell users which size to resize to
This is coming up here
idaholab/moose#22191 (reply in thread)
The text was updated successfully, but these errors were encountered: