Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Firefox check and make all browsers behave the same #119

Closed
rpearce opened this issue Jan 18, 2018 · 1 comment · Fixed by #121
Closed

Remove Firefox check and make all browsers behave the same #119

rpearce opened this issue Jan 18, 2018 · 1 comment · Fixed by #121

Comments

@rpearce
Copy link
Owner

rpearce commented Jan 18, 2018

This issue is a:

  • Other

Description

We should consider taking out the InstallTrigger Firefox check and make the same functionality happen across all the browsers. It's probably the safest thing to do.

Conversation Reference:
#117 (comment)

Basically, these lines (https://github.com/rpearce/react-medium-image-zoom/blob/master/src/Zoom.js#L87-L92)

const src = img.currentSrc || img.src

// See comment at top of file for Firefox check information
const newState = isFirefox ? { tmpSrc: src } : { src }

this.setState(newState)

should be changed to

this.setState({ tmpSrc: img.currentSrc || img.src })

and the isFirefox check should be removed.

cc @kingdido999 for talking sense into me.

@hippodippo
Copy link

I am happy to work/fix this. This will be my first code contribution though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants