-
-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Default classes for DIV elements #147
Comments
Hi @dsone, thank you for voicing your concern! Let's see if I can address all the things.
At the moment, those first two are there for nothing more than React rendering purposes and hanging on to some events (probably could be done better). The one that is highlighted is the fixed container, and the
While adding classnames specific to this library is not something I think is a good idea for a component, perhaps adjusting the API in the rewrite (which I've not gotten back to but is on my list of priorities) to encourage clear, fine-grained control is something I can think on as it gets rewritten. As far as the I'll keep this issue open until the rewrite occurs. |
Hi, we're not done with the rewrite yet, but we are keeping this in mind for the following rewrite issue: #165. |
As you can see when inspecting a zoomed image here, https://rpearce.github.io/react-medium-image-zoom/?path=/story/react-medium-image-zoom--with-img, we are using some class names for static styling (see image): The API for v4 allows for:
While |
This issue is a: "Feature" request
Description
Currently, there are three DIV elements added to the body on zoom and you have no clue what DIV is the overlay/zoomContainer.
That leads to issues similar to #127.
I was using the zoomContainer for custom styling, thinking that was the right one. Apparently, it wasn't.
It would be nice if the DIV containers would contain default class names. This would make it so much easier to do basic styling outside of the provided options of the package itself and support better understanding of what is added into the DOM.
The text was updated successfully, but these errors were encountered: