New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

`system-upgrade` doesn't upgrade group and environments #1817

Open

kontura opened this issue Nov 1, 2024 · 0 comments

Labels

Priority: HIGH Triaged

Contributor

kontura commented Nov 1, 2024

This is a problem when for example a definition of a group is extended in a new release, the new packages need to be installed.

Failing tests: https://github.com/rpm-software-management/ci-dnf-stack/blob/main/dnf-behave-tests/dnf/plugins-core/system-upgrade-comps.feature

I believe the SystemUpgradeDownloadCommand::run() needs something like:

libdnf5::comps::GroupQuery q_groups(ctx.get_base());
q_groups.filter_installed(true);
for (const auto & grp : q_groups) {
    goal->add_group_upgrade(grp.get_groupid());
}

(and similarly for environments)

The functionality was added to dnf4 here: rpm-software-management/dnf-plugins-extras#183

The text was updated successfully, but these errors were encountered:

kontura added Priority: HIGH Triaged labels

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment