Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dnf_repo_substitute missing shell-style variable expansion #1690

Closed
evan-goode opened this issue Feb 3, 2025 · 0 comments · Fixed by #1696
Closed

dnf_repo_substitute missing shell-style variable expansion #1690

evan-goode opened this issue Feb 3, 2025 · 0 comments · Fixed by #1696

Comments

@evan-goode
Copy link
Member

Shell-style variable expressions such as {releasever_minor:+.$releasever_minor} are not handled correctly by dnf_repo_substitute. This feature was added to libdnf in #1622.

dnf_repo_substitute calls librepo's lr_url_substitute. We should either port the new expression feature to librepo (which may have benefits elsewhere?), or possibly just call libdnf's existing ConfigParser::substitute from dnf_repo_substitute.

Causes https://issues.redhat.com/browse/RHEL-74025.
@evan-goode evan-goode changed the title dnf_repo_substitute missing shell-style variable expansion dnf_repo_substitute missing shell-style variable expansion Feb 3, 2025
evan-goode added a commit to evan-goode/libdnf that referenced this issue Feb 7, 2025
@evan-goode
C API: support shell-style variable substitution
a75c531 
Rework `dnf_repo_substitute` to call the C++ API's
ConfigParser::substitute instead of librepo's lr_url_substitute.

Resolves rpm-software-management#1690
@evan-goode evan-goode mentioned this issue Feb 7, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

C API: support shell-style variable substitution evan-goode/libdnf
1 participant
@evan-goode