Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple builds via the BuildArch tag do not work #2319

Closed
mlschroe opened this issue Dec 9, 2022 · 4 comments
Closed

Multiple builds via the BuildArch tag do not work #2319

mlschroe opened this issue Dec 9, 2022 · 4 comments
Assignees

Comments

@mlschroe
Copy link
Collaborator

mlschroe commented Dec 9, 2022

The documentation is somewhat lacking, but it seems to me that once upon a time specifying multiple elements in BuildArch resulted in multiple builds being done (if the buildarch is deemed compatible).

I think this was broken in 2001 with commit c3835f5, which changed the code
to always free the BASpecs array and returning the first element. After the change spec->recursing will always be set and the code in build.c that would loop over BASpecs is never used.

Should this be made to work again or should we drop support for multiple builds?

@mlschroe
Copy link
Collaborator Author

mlschroe commented Dec 9, 2022

Also, BuildArch seems to only set %_target_cpu. Shouldn't it also change the optflags?

@pmatilai
Copy link
Member

I really don't remember the behavior from those days, no strong opinion here. Other than agreeing on "it seems pretty broken in many places" that is.

As for optflags - yes, and BuildArch should arguably also (re)load platform macros while at it.

@ffesti
Copy link
Contributor

ffesti commented Oct 24, 2023

I also don't have too strong of an opinion on that. Only the comment that most build systems may be pretty surprised if suddenly packages from more than one build arch show up. May be we should keep things as they are and just clean up the code.

@ffesti
Copy link
Contributor

ffesti commented Oct 25, 2023

So I think going back to the old behaviour is just not worth the trouble - even if it may be easy to do code wise. So all that's left is cleaning up the code a little bit. Not keeping a ticket open for stuff like that - otherwise we had tickets for each line of RPM code...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants