x86/x87env failures

[GitMensch]

test 890
    Start  890: x86/x87env

890: Test command: /usr/bin/bash "source_dir/src/test/basic_test.run" "x87env" "" "bin_dir" "120"
890: Test timeout computed to be: 10000000
890: source_dir/src/test/util.sh: line 279: 139539 Illegal instruction     _RR_TRACE_DIR="$workdir" test-monitor $TIMEOUT record.err $RR_EXE $GLOBAL_OPTIONS record $LIB_ARG $RECORD_ARGS "$exe" $exeargs > record.out 2> record.err
890: Test 'x87env' FAILED: : token 'EXIT-SUCCESS' not in record.out:
890: --------------------------------------------------
890: --------------------------------------------------
890: Test x87env failed, leaving behind /tmp/rr-test-x87env-YcPkPggdE and /home/simon/rr/build/rr-test-x87env-RnI2KcIyu
890: To replay the failed test, run
890:   _RR_TRACE_DIR=/tmp/rr-test-x87env-YcPkPggdE rr replay
1/4 Test  #890: x86/x87env .......................***Failed  Error regular expression found in output. Regex=[FAILED]  0.17 sec
test 891
    Start  891: x86/x87env-no-syscallbuf

891: Test command: /usr/bin/bash "source_dir/src/test/basic_test.run" "x87env" "-n" "bin_dir" "120"
891: Test timeout computed to be: 10000000
891: source_dir/src/test/util.sh: line 279: 139567 Illegal instruction     _RR_TRACE_DIR="$workdir" test-monitor $TIMEOUT record.err $RR_EXE $GLOBAL_OPTIONS record $LIB_ARG $RECORD_ARGS "$exe" $exeargs > record.out 2> record.err
891: Test 'x87env' FAILED: : token 'EXIT-SUCCESS' not in record.out:
891: --------------------------------------------------
891: --------------------------------------------------
891: Test x87env failed, leaving behind /tmp/rr-test-x87env-AVWQ2baSU and /home/simon/rr/build/rr-test-x87env-Y2Rv6HZAf
891: To replay the failed test, run
891:   _RR_TRACE_DIR=/tmp/rr-test-x87env-AVWQ2baSU rr replay
2/4 Test  #891: x86/x87env-no-syscallbuf .........***Failed  Error regular expression found in output. Regex=[FAILED]  0.12 sec

on

uname -a && cat /proc/cpuinfo 
Linux machine 6.6.30-gnu #1.0 SMP PREEMPT_DYNAMIC Tue Sep 27 12:35:59 EST 1983 x86_64 x86_64 x86_64 GNU/Linux
processor	: 0
vendor_id	: GenuineIntel
cpu family	: 6
model		: 37
model name	: Intel(R) Core(TM) i5 CPU       M 460  @ 2.53GHz
stepping	: 5
microcode	: 0x2
cpu MHz		: 1197.195
cache size	: 3072 KB
physical id	: 0
siblings	: 4
core id		: 0
cpu cores	: 2
apicid		: 0
initial apicid	: 0
fpu		: yes
fpu_exception	: yes
cpuid level	: 11
wp		: yes
flags		: fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush dts acpi mmx fxsr sse sse2 ht tm pbe syscall nx rdtscp lm constant_tsc arch_perfmon pebs bts rep_good nopl xtopology nonstop_tsc cpuid aperfmperf pni dtes64 monitor ds_cpl vmx est tm2 ssse3 cx16 xtpr pdcm pcid sse4_1 sse4_2 popcnt lahf_lm pti tpr_shadow flexpriority ept vpid dtherm ida arat vnmi
vmx flags	: vnmi preemption_timer invvpid ept_x_only flexpriority tsc_offset vtpr mtf vapic ept vpid unrestricted_guest
bugs		: cpu_meltdown spectre_v1 spectre_v2 spec_store_bypass l1tf mds swapgs itlb_multihit mmio_unknown
bogomips	: 5054.81
clflush size	: 64
cache_alignment	: 64
address sizes	: 36 bits physical, 48 bits virtual
power management:

[khuey]

That CPU is 15 years old. We'd take a patch I guess but I can't say fixing this is a priority. I suspect the CPU doesn't have XSAVE and the test just needs to check for XSAVE and return early if it's not present.

Is that somehow the only test that fails on that CPU? I'd be pretty impressed if that's the case.

[GitMensch]

Yes, these tests (and unicode) are the only failing. So you say that's a false-positive only.
Where do I find an example what to apply for the test source, so I can provide a monkey-see-monkey-do PR?

[khuey]

You need to do something along the lines of find_xsave_size in src/test/x86/ptrace.c, but if xsave is not present just exit the test early.