Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Seeking repeatedly crashes chrome tab (when using virtual dom) #1160

Closed
1 task done
pdwittig opened this issue Feb 28, 2023 · 4 comments · Fixed by #1139
Closed
1 task done

[Bug]: Seeking repeatedly crashes chrome tab (when using virtual dom) #1160

pdwittig opened this issue Feb 28, 2023 · 4 comments · Fixed by #1139
Labels
bug Something isn't working

Comments

@pdwittig
Copy link

pdwittig commented Feb 28, 2023

Preflight Checklist

  • I have searched the issue tracker for a bug report that matches the one I want to file, without success.

What package is this bug report for?

rrweb

Version

2.0.0-alpha.5

Expected Behavior

I am able to seek without chrome tab crashing

Actual Behavior

Using the latest alpha version, with useVirtualDom: true, when I scrub around (drag progress bar or click seek forward or backward repeatedly, which calls player.play(time)) my chrome tab crashes with error code 5.

If I set useVirtualDom: false and scrub the tab does not crash.

Additionally, if I bump down to 2.0.0-alpha.4 I am not able to reproduce the bug with or without virtual DOM enabled.

This happens for every recording I play in my player, so I have not included a test set of events.

Additionally, I'm not really great at debugging these sort of issues, but I did run the chrome profiler, and it looks like it could be some sort of memory leak?
image

Let me know if I can provide any additional information to help debug. Thanks!

Steps to Reproduce

See above

Testcase Gist URL

No response

Additional Information

No response

@pdwittig pdwittig added the bug Something isn't working label Feb 28, 2023
@pdwittig pdwittig changed the title [Bug]: [Bug]: Seeking repeatedly crashes chrome tab (when using virtual dom) Feb 28, 2023
@Code-Crash
Copy link
Contributor

I'm also facing this issue in 2.0.0-alpha.5.

The attached image shows its CPU usage is at 100% and JS heap size is more than 1GB.

Screenshot 2023-03-08 at 12 13 31 PM

@YunFeng0817 YunFeng0817 linked a pull request Mar 8, 2023 that will close this issue
@YunFeng0817
Copy link
Member

YunFeng0817 commented Mar 8, 2023

I've fixed this bug in #1139, @Juice10 could you please review my code these days? This issue is urgent I think.
image

@YunFeng0817
Copy link
Member

2.0.0-alpha.6 is available with the fix.

@Code-Crash
Copy link
Contributor

Thank @YunFeng0817, it's working now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants