Skip to content
This repository was archived by the owner on Oct 23, 2022. It is now read-only.

dag/resolve: should return without loading the block for empty paths #237

Closed
koivunej opened this issue Jul 10, 2020 · 2 comments
Closed
Labels
bug Something isn't working http ipfs-http or the http api

Comments

@koivunej
Copy link
Collaborator

This affects #236. Having previously gone back and forth with the "initial block" blocking I wonder if this is something which was changed recently in the conformance tests.

@koivunej koivunej added bug Something isn't working http ipfs-http or the http api labels Jul 10, 2020
@koivunej
Copy link
Collaborator Author

koivunej commented Jul 10, 2020

Wondering if this should affect how the "the upcoming" ipfs::Ipfs::resolve or at the moment ipfs_http::v0::refs::walk_path should work, or if this should be just hacked in dag/resolve. Wrote #238 on "the upcoming ...::resolve".

@koivunej
Copy link
Collaborator Author

I was expecting this "bug" to be hit during #229 however it wasn't, so I must have misunderstood the bug cause. Good if this doesn't need to be touched at least for now (I've danced with this perhaps in #184).

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working http ipfs-http or the http api
Projects
None yet
Development

No branches or pull requests

1 participant