Fixing race in SDWebImageDownloaderOperation leading to erroneous timeout. #698
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixing race condition that causes cancellation of one download operation to stop a run loop that is now used for another download operation. Race is introduced through -performSelector:onThread:withObject:waitUntilDone:
salling
changed the title
rs
pushed a commit
that referenced
this pull request
Apr 22, 2014
Fixing race in SDWebImageDownloaderOperation leading to erroneous timeout.
|
@salling I'm using your patch but sometimes still seeing it happen. How could we make the architecture more capable of handling this? Refactor to use dispatch_queues and one run loop? |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some cases, SDWebImage will erroneously report timeout for an image download. This is due to a race condition introduced through -performSelector:onThread:withObject:waitUntilDone:, which causes cancellation of a download operation to stop the run loop that is now used for another download operation.