Pass imageURL in completedBlock #770
Conversation
- deprecated block type `SDWebImageCompletedWithFinishedBlock`, replaced with `SDWebImageCompletionWithFinishedBlock` that contains NSURL* param - deprecated SDWebImageManager `-downloadWithURL:options:progress:completed:` method. Replaced with `downloadImageWithURL:options:progress:completed:` that uses the `SDWebImageCompletionWithFinishedBlock ` as completion block type - created Deprecated category for SDWebImageManager containing the old method - replaced the usages of the deprecated items with the new ones
- created block type `SDWebImageCompletionBlock` that contains NSURL* param - deprecated all MKAnnotationView(WebCache) `setImage*` methods. Replaced with `loadImage*` methods that use the `SDWebImageCompletionBlock` as completion block type - created WebCacheDeprecated category on MKAnnotationView (to avoid collisions, we didn't name it Deprecated) - replaced the usages of the deprecated items with the new ones
- deprecated all UIButton(WebCache) `setImage*` methods. Replaced with `loadImage*` methods that use the `SDWebImageCompletionBlock` as completion block type - created WebCacheDeprecated category on UIButton (to avoid collisions, we didn't name it Deprecated) - replaced the usages of the deprecated items with the new ones
… completion block) + alignaments
…on block) + alignaments
- deprecated all UIImageView(HighlightedWebCache) `setImage*` methods. Replaced with `loadImage*` methods that use the `SDWebImageCompletionBlock` as completion block type - created HighlightedWebCacheDeprecated category on UIImageView (to avoid collisions, we didn't name it Deprecated) - replaced the usages of the deprecated items with the new ones
- deprecated all UIImageView(WebCache) `setImage*` methods. Replaced with `loadImage*` methods that use the `SDWebImageCompletionBlock` as completion block type - created WebCacheDeprecated category on UIImageView (to avoid collisions, we didn't name it Deprecated) - replaced the usages of the deprecated items with the new ones
- deprecated block type `SDWebImageCompletedBlock `, replaced with `SDWebImageCompletedBlock ` that contains NSURL* param
|
@rs please take a good look at this. I think it's all good, but you know this code better than anyone. Thanks in advance. |
|
I think this is a good pull request. |
|
Why do we change the whole API and add so much burden just to add a param to the callback? I would be more comfortable by keeping the lib clean of deprecated code and just make the backward incompatible change in a major release. It won't break dependent apps as they won't compile and force devs to update their code. We may carefully document this change to help people migrate their code easily. |
|
Why wait for a major release.... when we can do this... deprecate old On Thu, Jun 19, 2014 at 11:17 AM, Olivier Poitrey notifications@github.com
Kind regards, |
|
What about breaking it now and say the next release is a major? I really don't like the idea to change method names semantic just because we introduce a change in the rest of the method's prototype. |
|
At least, if you really need to do that, don't change the semantic and add a prefix to the category methods (i.e.: |
|
@rs I totally understand your point about keeping the library clean. But I don't think what we have right now for the next version qualifies for a major release (other than if we were breaking compatibility). I think the approach you suggested (prefixing the method names) is great and I vote for that. I will go ahead and update my pull request. Please let me know if you disagree so I don't do that. |
|
I updated with the sd prefixes for all the category methods. Please review |
|
That's better. We now have to make sure we clean those deprecated methods in the next major otherwise it will still conflict with |
|
I created a 4.0.0 milestone and issue #774 set on 4.0.0 that will remind us to clean those up. Could you merge it now? |
|
Yes |
|
Thank you |
|
Thanks guys On Thursday, June 19, 2014, Bogdan Poplauschi notifications@github.com
Kind regards, |
Redone #759 (contained some changes that were already merged, did not replace and deprecate all methods, method names could be better, wanted to redo the docs, indentation was inconsistent):
SDWebImageCompletedWithFinishedBlock, replaced withSDWebImageCompletionWithFinishedBlockthat contains NSURL* paramSDWebImageCompletedBlock, replaced withSDWebImageCompletedBlockthat contains NSURL* param-downloadWithURL:options:progress:completed:method. Replaced withdownloadImageWithURL:options:progress:completed:that uses theSDWebImageCompletionWithFinishedBlockas completion block typesetImage*methods. Replaced withloadImage*methods that use theSDWebImageCompletionBlockas completion block typesetImage*methods. Replaced withloadImage*methods that use theSDWebImageCompletionBlockas completion block typesetImage*methods. Replaced withloadImage*methods that use theSDWebImageCompletionBlockas completion block typesetImage*methods. Replaced withloadImage*methods that use theSDWebImageCompletionBlockas completion block typeAlso managed to get rid of the naming collision with the AFNetworking UIImageView category methods. Now we use
loadImageWithURL:instead ofsetImageWithURL:.Fixes: #350, #722
PS: many thanks @ilushka85 for doing the heavy lifting on this