Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace #621Fixed race condition between operation cancelation and loading finish #783

Merged
merged 1 commit into from
Jul 11, 2014

Conversation

bpoplauschi
Copy link
Member

See all the details in #621

@bpoplauschi bpoplauschi added this to the 3.7.0 milestone Jun 25, 2014
@bpoplauschi
Copy link
Member Author

@rs could you please review and merge this (if you're ok with the changes)?

@bpoplauschi
Copy link
Member Author

@rs could you please look at this too?

@rs
Copy link
Member

rs commented Jul 10, 2014

Looks good

@bpoplauschi
Copy link
Member Author

Merging, based on @rs's comment.

bpoplauschi added a commit that referenced this pull request Jul 11, 2014
Replace #621Fixed race condition between operation cancelation and loading finish
@bpoplauschi bpoplauschi merged commit 39db378 into SDWebImage:master Jul 11, 2014
@bpoplauschi bpoplauschi deleted the race_condition branch July 11, 2014 06:57
@dulgan
Copy link
Contributor

dulgan commented Jul 11, 2014

@bpoplauschi Nice work here, My app run just way better than before, this was the exact problem I had 👍
@rs It just need to be updated in CocoaPods, thanks ! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants