Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix duplicate symbols when using with webp via pods #795

Merged
merged 1 commit into from
Jul 21, 2014

Conversation

mr-slippery-2861
Copy link

When build SDWebImage with webp support, it will fail due to "duplicate symbols".

@bpoplauschi bpoplauschi added this to the 3.7.0 milestone Jul 10, 2014
@bpoplauschi
Copy link
Member

I tried to repro this, but I get strange compiler errors (like the ones described here #494). It seems those issues were fixed in libwebp, but they never released an update since December 2013, even though they are actively working on the project.

Regarding the issue you are addressing, I can't say if they work or not.

@bpoplauschi bpoplauschi modified the milestones: Future, 3.7.0 Jul 10, 2014
@leafduo
Copy link

leafduo commented Jul 11, 2014

As discussed in #494, it's a bug in current version of libwebp. libwebp does not support ARM64 correctly, therefore disabling ARM64 support will confirm this pull request works.

@bpoplauschi
Copy link
Member

I removed the arm64 support and everything compiled fine, without your fix. I'm not sure I follow

@leafduo
Copy link

leafduo commented Jul 11, 2014

Did you install webp support via CocoaPods? Like pod 'SDWebImage/WebP'

@bpoplauschi
Copy link
Member

Yeap. That's exactly what I did.

platform :ios, '6.1'
pod 'SDWebImage/WebP', :head

@leafduo
Copy link

leafduo commented Jul 11, 2014

OK, I find the reason.

We have -all_load set in other linker flags.

@bpoplauschi bpoplauschi modified the milestones: 4.0.0, Future Jul 15, 2014
@leafduo
Copy link

leafduo commented Jul 20, 2014

Any update?

@bpoplauschi
Copy link
Member

I will try with the -all_load flag today or tomorrow. Stay tuned :)

@bpoplauschi bpoplauschi modified the milestones: 3.7.1, 4.0.0 Jul 21, 2014
@bpoplauschi
Copy link
Member

Hey @leafduo, I just tried with the -all_load flag and I do get the duplicate symbols error. With the fix from @xlChen, everything is ok. I will merge this fix. Thank you both for the support.

bpoplauschi added a commit that referenced this pull request Jul 21, 2014
fix duplicate symbols when using with webp via pods
@bpoplauschi bpoplauschi merged commit 222e6bc into SDWebImage:master Jul 21, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants