Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why the bootstrap 4 dependency? #31

Closed
igor-pavlichenko opened this issue Mar 9, 2020 · 4 comments
Closed

Why the bootstrap 4 dependency? #31

igor-pavlichenko opened this issue Mar 9, 2020 · 4 comments

Comments

@igor-pavlichenko
Copy link

igor-pavlichenko commented Mar 9, 2020

It's specified in the dependencies as "bootstrap": "^4.1.3",, what is it used for here?

For some reason it's breaking my angular 9 project that uses bootstrap-sass 3 in legacy code. It's related to sass exports/imports.

@pedrotoch
Copy link

Same happens to me as soon as I update ngx-custom-validators to latest version. Also using bootstrap-sass 3.

@YZahringer
Copy link

Same issue, with warning on npm audit

WARN bootstrap@4.4.1 requires a peer of jquery@1.9.1 - 3 but none is installed. You must install peer dependencies yourself.

WARN bootstrap@4.4.1 requires a peer of popper.js@^1.16.0 but none is installed. You must install peer dependencies yourself.

@igor-pavlichenko
Copy link
Author

igor-pavlichenko commented Mar 10, 2020

@rsaenen you are using bootstrap for development/testing purposes in /src/dev so my guess is that it should be moved back to devDependencies

Edit:
I made a PR. Would be awesome if you could review it and release a new minor version. Let me know if there's anything wrong with it.

@rsaenen
Copy link
Owner

rsaenen commented Mar 11, 2020

@igor-pavlichenko thanks a lot !

Released with 9.0.1

@rsaenen rsaenen closed this as completed Mar 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants