Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggest: change datatype variable name in ML code #79

Open
Neves-P opened this issue Sep 23, 2019 · 1 comment
Open

Suggest: change datatype variable name in ML code #79

Neves-P opened this issue Sep 23, 2019 · 1 comment

Comments

@Neves-P
Copy link
Collaborator

Neves-P commented Sep 23, 2019

DAISIE_ML_CS contains the argument datatype, which can be single or multiple.

I suggest changing this name, as it implies (at least it lead me in that direction) that an ML run in a 2 species type scenario should be expected (i.e. run DAISIE_ML2). In fact, it determines if single island or archipelago scenario should be expected (and DAISIE_ML1 runs).

@richelbilderbeek
Copy link
Collaborator

I think it should be encouraged to make code more expressive. I am happy to read what the current name implies, but I wonder:

  • What does the variable do?
  • What do you suggest to name the variable to?

As a side-note, apparently you can also suggest better names for DAISIE_ML1 and DAISIE_ML2 as well 🌈

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants