Return JSON-RPC error on eth_call revert

Author: colltoaction

rskj-core/src/main/java/co/rsk/rpc/modules/eth/EthModule.java

@@ -30,6 +30,7 @@
 import org.ethereum.rpc.Web3;
 import org.ethereum.rpc.converters.CallArgumentsToByteArray;
 import org.ethereum.rpc.dto.CompilationResultDTO;
+import org.ethereum.rpc.exception.JsonRpcExecutionErrorException;
 import org.ethereum.vm.PrecompiledContracts;
 import org.ethereum.vm.program.ProgramResult;
 import org.slf4j.Logger;
@@ -103,6 +104,10 @@ public String call(Web3.CallArguments args, String bnOrId) {
         try {
             Block executionBlock = executionBlockRetriever.getExecutionBlock(bnOrId);
             ProgramResult res = callConstant(args, executionBlock);
+            if (res.isRevert()) {
+                throw new JsonRpcExecutionErrorException.TransactionReverted();
+            }
+
             return s = toJsonHex(res.getHReturn());
         } finally {
             LOGGER.debug("eth_call(): {}", s);

rskj-core/src/main/java/org/ethereum/rpc/exception/JsonRpcExecutionErrorException.java

@@ -0,0 +1,33 @@
+/*
+ * This file is part of RskJ
+ * Copyright (C) 2018 RSK Labs Ltd.
+ *
+ * This program is free software: you can redistribute it and/or modify
+ * it under the terms of the GNU Lesser General Public License as published by
+ * the Free Software Foundation, either version 3 of the License, or
+ * (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ * GNU Lesser General Public License for more details.
+ *
+ * You should have received a copy of the GNU Lesser General Public License
+ * along with this program. If not, see <http://www.gnu.org/licenses/>.
+ */
+
+package org.ethereum.rpc.exception;
+
+public class JsonRpcExecutionErrorException extends RskJsonRpcRequestException {
+
+    private JsonRpcExecutionErrorException(String message) {
+        super(-32015, String.format("VM execution error: %s", message));
+    }
+
+    public static class TransactionReverted extends JsonRpcExecutionErrorException {
+
+        public TransactionReverted() {
+            super("transaction reverted");
+        }
+    }
+}