Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use incremental build feature of esbuild #20

Closed
schickling opened this issue Dec 14, 2020 · 3 comments
Closed

Use incremental build feature of esbuild #20

schickling opened this issue Dec 14, 2020 · 3 comments
Labels
enhancement New feature or request

Comments

@schickling
Copy link

Thanks again for this great tool @rsms 🙏

To speed up estrella further when continuously rebuilding a project, it's now possible to use the new incremental build feature.

Note: I've done some quick scan of the code base if this is already the case but couldn't find any indication for this. If you're already using esbuild's incremental build feature, please just close this issue.

@rsms rsms added the enhancement New feature or request label Dec 19, 2020
@rsms
Copy link
Owner

rsms commented Dec 19, 2020

Great idea! Happy to accept a PR for this, by the way.

@myobie
Copy link
Contributor

myobie commented Jan 3, 2021

{ incremental: !!cliopts.watch } appears to me to be passed through to esbuild. Is there more to do than just include it in the build arguments?

@rsms
Copy link
Owner

rsms commented Mar 21, 2021

Added in 7a2bd8f (forgot to mention the GitHub issue) and will be included with the next release.

@rsms rsms closed this as completed Mar 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants