-
-
Notifications
You must be signed in to change notification settings - Fork 409
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Accents below lowercase letters can be more compact #145
Comments
Agreed! I can see if I can fix this tonight. |
Closed by e1d8712 |
Having checked the latest version, it's looking better! However, I vote that we make one more iteration of this. The remaining problemIn the latest version, the A small problem is that in certain software, this may partially cutoff the bottom curve of the /y glyph. The bigger problem is when a user tries to use the font for interface design in Sketch – say, to mockup a button. If they vertically-center a textbox of Inter with a button shape, the text will look substantially below-center. In a font like SF, it looks much more vertically-centered, by default. (Honestly, SF isn't perfect for this, but it's pretty close – and there's no reason Inter shouldn't be nicer to use for interface design 🙂). This is also a problem for users trying to use Inter in other Mac apps – say, to make a presentation in Keynote. Here's Inter vs SF, with center vertical alignment in Keynote: This alignment will probably annoy the heck out of obsessive designers like myself. 😄 But what about in an actual web browser?I made a quick codepen to take a look at how things are working in an actual web browser: https://codepen.io/thundernixon/pen/RONBKV Here, it looks like the typo metrics are being properly respected, and this puts both fonts nicely in the vertical center, without issue: So, should we change the
|
Update: yessss I think I actually properly nailed down a solution that tests well on multiple tricky fronts, after some trial-and-error. Will PR later tonight! |
Just released v3.5 containing these recent changes. |
Describe the bug
While looking into vertical metrics standards for Google Fonts, I realized that my recent PR to Inter was probably not optimal: it's default line height is significantly higher than most comparable fonts.
The root cause of this is that the script I set the vertical metrics with. It sets the
winDescent
to the lowest y-coordinate in the font. Meanwhile,winAscent
is the highest y-coordinate in the font (Å).This helps avoid clashes between lines of text, becausewinDescent
andwinAscent
are used for the total default line height.Actually, the MS OpenType spec says:
...but these still seem to be the values used in Sketch & TextEdit. I need to do a bit more research to compare vertical metric values in fonts similar to Inter to know for sure.
However, I believe the design suggestions in this issue are valid, either way.
In Inter, the
/ydotbelow
glyph has a dot below its descender. This is logical, but seemingly not typical – many other fonts put it to the right of they
. In the case of Inter, it means that theTypoDescender
is quite low, and as a result, the default line height is abnormally large.Here are several fonts set at their default line heights, in Sketch:
And one with Inter's line height reduced:
Expected behavior
I propose two changes:
ydotbelow
dot is moved up and to the right, as in comparable fontscommaaccentbelow
is made slightly more compact (less critical, but still useful). It is the second-lowest object in the font, and significantly bigger than commaaccents from related designs.Environment
Version 3.004;git-8321f7c65
Additional context
I wanted to note down my research in an issue, and (unless something big comes up) I'll change these things tomorrow, adjust the vertical metrics again, and submit another PR. Vertical metrics are some of the more important things to really get right before we publish to Google Fonts, because it will obviously make a very big difference to people's layouts if these change after the font is implemented in websites, etc.
The text was updated successfully, but these errors were encountered: