Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

case + calt does not replace -> with arrow #161

Closed
VasiliyRusin opened this issue May 22, 2019 · 6 comments
Closed

case + calt does not replace -> with arrow #161

VasiliyRusin opened this issue May 22, 2019 · 6 comments
Labels
bug Something that is now the way it's supposed to be

Comments

@VasiliyRusin
Copy link

VasiliyRusin commented May 22, 2019

Describe the bug
First of all. I'm not sure what it's a bug, but it looks pretty bad. And according to the demo from the website, it should be nicer.

image

If I use font-feature-settings: 'case' 1;, I lose alt case, but if I didn't use it, my symbols jump with a different case.

UPD.

Now I absolutely sure that it's a bug. Most features of 'calt' work as expected with font-feature-settings: 'case' 1;. But arrows not. The demo was updated.

image

To Reproduce
Just watch demo.

Expected behaviour
I hoped to get both of these. Fixed vertical position and alt case.

Screenshots
image

Environment

  • OS: Windows 10 1809

  • Chrome and Affinity Designer. But I suppose that it will be on any app.

  • Current version from css file.

@reli-msft
Copy link

font-feature-settings: 'case' 1; will turn on case feature only. If you need calt you need to write font-feature-settings: 'case' 1, 'calt' on;

@VasiliyRusin
Copy link
Author

VasiliyRusin commented May 23, 2019

font-feature-settings: 'case' 1; will turn on case feature only. If you need calt you need to write
font-feature-settings: 'case' 1, 'calt' on;

First of all, calt is on by default. But even if I on it, it won't work.

@reli-msft
Copy link

@VasiliyRusin @rsms
I see the problem: In lookup 39, uni2192.case is built up with uni002D.case and uni003E, where the latter glyph should be uni003E.case. This mistake also happened in other arrow combinations.

image

@rsms
Copy link
Owner

rsms commented May 26, 2019

Good catch!

@rsms rsms added the bug Something that is now the way it's supposed to be label May 26, 2019
@rsms rsms changed the title case with calt case + calt does not replace -> with arrow May 26, 2019
@rsms rsms closed this as completed in 39213de May 26, 2019
@rsms
Copy link
Owner

rsms commented May 26, 2019

With fix landed in 39213de:
Screen Shot 2019-05-26 at 16 15 04

@rsms
Copy link
Owner

rsms commented May 27, 2019

Shipped with release 3.6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something that is now the way it's supposed to be
Projects
None yet
Development

No branches or pull requests

3 participants