Skip to content

Missing interfaces and class in DotNet RSocket.Core Nuget package version 1.0.0 #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
clrsky opened this issue Jul 24, 2020 · 3 comments

Comments

@clrsky
Copy link

clrsky commented Jul 24, 2020

@OlegDokuka , we observed that a new version 1.0.0 was available from nuget on 23rd july 2020
It was observed that few classes and interface available in 0.2.3 are not available in the new version
For ex: IRSocketChannel and RSocketOptions are not longer available

Expected Behavior

From yesterdays code merge and discussion done with Reetesh Agarwal's team ,we were expecting that the same changes would be available related to PR #11

Actual Behavior

Some of the interfaces and classes are no longer available and code seems to contain few different method and classes.
Please confirm if its from the same source and 1.0.0 is the intended version to be used.

Attaching a comparison screen shot for reference:
image

@clrsky
Copy link
Author

clrsky commented Jul 25, 2020

@OlegDokuka , updated the query with name of the discussion team involved for more clarity.
Kindly help us in clarification of the above query to help us move forward.

@OlegDokuka
Copy link
Member

this is a wrong, old version which was added accidentally and should not be used. The appropriate one is 0.2.3.

Please use classes and code structure from 0.2.3

@clrsky
Copy link
Author

clrsky commented Jul 29, 2020

Thank you @OlegDokuka

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants