Merge pull request #1104 from palfvin/2-99-its

Deprecate 'its' in favor of rspec-its gem as part of #1083

Author: JonRowe

Changelog.md

@@ -29,6 +29,8 @@ Deprecations
   RSpec 3 will not support having this option set to `false` (Myron Marston).
 * Deprecate accessing a `let` or `subject` declaration in
   a `after(:all)` hook. (Myron Marston, Jon Rowe)
+* Deprecate built-in `its` usage in favor of `rspec-it` gem due to planned
+  removal in RSpec 3 (Peter Alfvin)
 
 ### 2.14.5 / 2013-08-13
 [full changelog](http://github.com/rspec/rspec-core/compare/v2.14.4...v2.14.5)

lib/rspec/core/memoized_helpers.rb

@@ -455,6 +455,7 @@ def subject!(name=nil, &block)
         #     its(:age) { should eq(25) }
         #   end
         def its(attribute, &block)
+          RSpec.deprecate('Use of rspec-core\'s "its" method', :replacement => 'rspec-its gem')
           describe(attribute) do
             if Array === attribute
               let(:__its_subject) { subject[*attribute] }

spec/rspec/core/memoized_helpers_spec.rb

@@ -348,6 +348,12 @@ def not_ok?; false; end
     end
 
     describe "#its" do
+
+      it "should issue deprecation warning" do
+        expect_deprecation_with_call_site(__FILE__, __LINE__+1, '"its" method')
+        RSpec::Core::ExampleGroup.its(nil) {}
+      end
+
       subject do
         Class.new do
           def initialize

spec/support/helper_methods.rb

@@ -23,9 +23,10 @@ def safely
     end
   end
 
-  def expect_deprecation_with_call_site(file, line)
+  def expect_deprecation_with_call_site(file, line, deprecated = //)
     expect(RSpec.configuration.reporter).to receive(:deprecation) do |options|
       expect(options[:call_site]).to include([file, line].join(':'))
+      expect(options[:deprecated]).to match(deprecated)
     end
   end