Fix our simplecov setup.

Simplecov was only reporting coverage for a handful
of rspec's files, and I realized why: simplecov can
only track coverage of files that are loaded _after_
it has been loaded. So, to get this to work properly,
we have to load simplecov before rspec-core. This
commit adds a wrapper script that does that.

Author: myronmarston

script/rspec_with_simplecov

@@ -0,0 +1,30 @@
+#!/usr/bin/env ruby
+
+# This is necessary for when `--standalone` is being used.
+$:.unshift File.expand_path '../../bundle', __FILE__
+require 'bundler/setup'
+
+# To use simplecov while running rspec-core's test suite, we must
+# load simplecov _before_ loading any of rspec-core's files.
+# So, this executable exists purely as a wrapper script that
+# first loads simplecov, and then loads rspec.
+begin
+  # Simplecov emits some ruby warnings when loaded, so silence them.
+  old_verbose, $VERBOSE = $VERBOSE, false
+
+  unless ENV['NO_COVERAGE'] || RUBY_VERSION < '1.9.3'
+    require 'simplecov'
+
+    SimpleCov.start do
+      add_filter "./bundle/"
+      add_filter "./tmp/"
+      add_filter "./spec/"
+      minimum_coverage 97
+    end
+  end
+rescue LoadError
+ensure
+  $VERBOSE = old_verbose
+end
+
+load File.expand_path("../../exe/rspec", __FILE__)

script/test_all

@@ -18,7 +18,7 @@ export JRUBY_OPTS='-X-C' # disable JIT since these processes are so short lived
 export JAVA_OPTS='-client -XX:+TieredCompilation -XX:TieredStopAtLevel=1'
 
 echo "Running all..."
-bin/rspec spec -b --format progress --profile
+script/rspec_with_simplecov spec -b --format progress --profile
 
 echo
 echo "--------------------------------------------------------------------"
@@ -28,7 +28,7 @@ if is_jruby; then
   echo "Skipping one-by-one spec runs due to expensive JVM load time"
 else
   for file in `find spec -iname '*_spec.rb'`; do
-    NO_COVERALLS=1 bin/rspec $file -b --format progress
+    bin/rspec $file -b --format progress
   done
 fi
 

spec/spec_helper.rb

@@ -24,10 +24,6 @@ module ArubaLoader
     end
   end
 
-  RSpec::Support::Spec.setup_simplecov do
-    minimum_coverage 96
-  end
-
   if RUBY_PLATFORM == 'java'
     # Works around https://jira.codehaus.org/browse/JRUBY-5678
     require 'fileutils'