-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove all spec views on destroy controller #2475
Conversation
Awesome! Can you please add specs for this change? |
EDIT:
EDIT2: |
@pirj found a workaround, ready to be reviewed again |
Hello @Naokimi and thanks for you PR. Tested locally and it is looks good to me. |
Do we have this problem with other generators? Do we want to ensure we're consistent? |
seems like other generators work as intended |
remove all spec views on destroy controller
Actions:
rails g controller Authors index show
rails d controller Authors
Current
ON GENERATE
Rails generates controller and view files
Rspec generates controller and view files
ON DESTROY
Rails destroys controller and view files
Rspec destroys only controller
Proposal
ON DESTROY
Rails destroys controller and view files
Rspec destroys controller and view files