-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove jQuery dependency #28
Conversation
👍 |
1 similar comment
+1 |
define(['jquery'], function($) { | ||
return factory($); | ||
define(function() { | ||
return factory(); | ||
}); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
define(factory);
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good call 👍
👍 |
Go! |
+1 👍 |
Awesome - working for me on 1.7.x |
this is awesome! |
👍 libraries like this should be independent as much as possible. |
👍 |
Cool, let me try to review this in the coming days. cheers! |
This is a very good idea |
👍 I just used this last hackathon. |
Any updates on merging this? |
👍 |
Yes, please make this a vanilla JavaScript library. Thanks! |
+1 for merging this and removing the jquery dependency. |
Thanks! Sorry this took a while. |
Out in v0.1.3, thanks @rurjur everyone! |
Addresses #7 (jQuery independence) and #17 (vendor prefixes).
DOM helpers added:
CSS helpers added:
Queue helper added:
Should be a good start, there's bound to be something I've missed.