Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How best to comment on proposal? #4

Open
dpastoor opened this issue Mar 9, 2018 · 1 comment
Open

How best to comment on proposal? #4

dpastoor opened this issue Mar 9, 2018 · 1 comment

Comments

@dpastoor
Copy link

dpastoor commented Mar 9, 2018

It didn't seem like a PR is appropriate, as it was more commentary, rather than changes. I thought maybe going to git blame and then commenting in-line in the latest commit that edited that line, but that seems hard to track conversations over time.

Very exciting proposal!

@romainfrancois
Copy link
Member

I believe in PR that are not necessarily meant to be merged. see e.g. this article from @yihui
https://yihui.name/en/2017/09/pull-requests-as-a-teaching-tool/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants