nargs: keep repeatable behaviour

- parts only consists of args related to current occurrence

example-nonposix/cmd/root.go

@@ -43,7 +43,7 @@ func init() {
 		"delim-colon": carapace.ActionValues("d1", "d2", "d3"),
 		"delim-slash": carapace.ActionValues("d1", "d2", "d3"),
 		"nargs-any": carapace.ActionCallback(func(c carapace.Context) carapace.Action {
-			return carapace.ActionValues("na1", "na2", "na3").Invoke(c).Filter(c.Parts).ToA()
+			return carapace.ActionValues("na1", "na2", "na3").Invoke(c).Filter(c.Parts).ToA() // only filters current occurrence
 		}),
 		"nargs-two": carapace.ActionCallback(func(c carapace.Context) carapace.Action {
 			switch len(c.Parts) {

internal/pflagfork/flag.go

@@ -28,21 +28,6 @@ func (f Flag) Nargs() int {
 	return 0
 }
 
-func (f Flag) Parts() []string {
-	if t := f.Value.Type(); !strings.HasSuffix(t, "Array") && !strings.HasSuffix(t, "Slice") {
-		return []string{}
-	}
-
-	toParse := f.Value.String()
-	toParse = strings.TrimPrefix(toParse, "[")
-	toParse = strings.TrimSuffix(toParse, "]")
-	if parts, err := readAsCSV(toParse); err == nil {
-		// TODO fails with StringArray (works with StringSlice)
-		return parts
-	}
-	return []string{}
-}
-
 func readAsCSV(val string) ([]string, error) {
 	if val == "" {
 		return []string{}, nil

internalActions.go

@@ -87,11 +87,6 @@ func actionFlags(cmd *cobra.Command) Action {
 				return // skip flag of group already set
 			}
 
-			if f.Changed && f.Nargs() > 0 && len(f.Parts()) >= f.Nargs() { // TODO optimize
-				// TODO only works with StringSlice at the moment
-				return // don't repeat nargs flag that has consumed all its required arguments
-			}
-
 			s := style.Carapace.FlagNoArg
 			if f.TakesValue() {
 				if f.IsOptarg() {

traverse.go

@@ -152,7 +152,7 @@ loop:
 	// flag argument
 	case inFlag != nil && inFlag.Consumes(context.CallbackValue):
 		logger.Printf("completing flag argument of %#v for arg %#v\n", inFlag.Name, context.CallbackValue)
-		context.Parts = inFlag.Parts() // TODO check for various flag types (bool,int,...)
+		context.Parts = inFlag.Args
 		return storage.getFlag(c, inFlag.Name), context
 
 	// flag