Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove lightgbm support? #24

Closed
simonpcouch opened this issue Aug 8, 2022 · 1 comment · Fixed by #25
Closed

remove lightgbm support? #24

simonpcouch opened this issue Aug 8, 2022 · 1 comment · Fixed by #25

Comments

@simonpcouch
Copy link
Collaborator

lightgbm currently has a dedicated bundling method, but will not need one when support for serialization via saveRDS + readRDS in the dev R package version (implemented in microsoft/LightGBM#4685) hits CRAN. It may be worth removing the lightgbm support before our initial CRAN release so we don't need to work through a deprecation cycle for those bundlers.

Their release timeline here: microsoft/LightGBM#5153

Related to tidymodels/bonsai#44—thanks for the note, @jameslamb. :)

@juliasilge
Copy link
Member

This sounds like a good plan; let's remove the lightGBM support before the initial CRAN release. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants