Release learnr 0.11.3

[gadenbuie]

• git pull
• Check current CRAN check results
  • NOTE: Undeclared packages ‘sortable’, ‘bslib’ in Rd xrefs
• Polish NEWS
  • Patch release, so the current structure should be fine
• urlchecker::url_check()
• devtools::build_readme()
• devtools::check(remote = TRUE, manual = TRUE)
• devtools::check_win_devel()
• revdepcheck::cloud_check()
• Update cran-comments.md
• git push

Submit to CRAN:

• usethis::use_version('patch')
• devtools::submit_cran()
• Approve email

Wait for CRAN...

• Accepted 🎉
• usethis::use_github_release()
• usethis::use_dev_version(push = TRUE)

[rossellhayes]

@gadenbuie We're currently getting this NOTE:

Undeclared packages ‘sortable’, ‘bslib’ in Rd xrefs

Are we purposefully leaving those packages out of Suggests?

[gadenbuie]

I don't mind the NOTE (unless CRAN does) so my stance has been to ignore it for now. I don't think anything bad happens for users if they look at those docs but don't have bslib or sortable. I personally don't think documentation links are a strong enough reason to suggest a package, but if I'm overlooking a problem, or if CRAN asks, I'd add them.

[schloerke]

What about replacing the link to their respective websites?

[gadenbuie]

Or that. Or... roxygen2 should have an "if installled" link type that does that for us automatically. 😊

But if the only harms are the note and a non-link I'm not convinced a change is needed. (If an invalid link is generated, that would change my mind for sure.)

[gadenbuie]

If the package isn't installed, the link is broken. I'll add both packages to Suggests.