-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add html_vignette function #108
Comments
It seems that such a change would allow to build Rmd vignettes without even C++ compiler installed, as none of the deps of knitr and markdown uses C++. Whatever compiled code is there it seems to be C only. |
There is no need to add a vignette format in the markdown package. You can change the vignette engine from Line 15 in d4fe00c
This will reduce a lot of indirect dependencies because rmarkdown has a lot of them, but note that you cannot avoid the dependency on knitr (which has become much lighter), so the actual dependencies will be:
Yes, these two features are supported, e.g., Lines 5 to 10 in d4fe00c
Docs: |
Yes, it could be consider this closed, unless... you would be willing to provide a wrapper |
That's an appealing proposal. Let me think more about it. Thanks! |
having this, it will finally feel as feature complete ;) |
Done now. Thanks again! BTW (off-topic), personally I feel very concerned by the current status of data.table. I'd strongly recommend that the new team can get 1.14.10 released soon and complete the transfer of maintainership. You will have plenty of time to discuss the rest of issues, but the CRAN check failures really need to be addressed right now (literally). I guess the only reason that this package has not been archived is that it has a large number of reverse dependencies, and CRAN can't just kill them all, otherwise they would have archived it several months ago. I have never seen a package that can survive for so long on CRAN with check errors before. If there are any issues blocking the 1.14.10 release, you can use temporary workarounds. For example, if certain tests are failing and you can't figure out how to fix them, it's fine to simply disable these tests for the 1.14.10 release. The top priority is to make sure data.table can continue to safely stay on CRAN, and make CRAN maintainers happy. Losing the "CRAN credit" is dangerous for package maintainers. |
FYI the new version is on CRAN now. You can use |
Thanks. Eliminating knitr would be great as well, it is now the most heavy dependency for data.table. Although I am happy it is not c++ so compilation time is rather minimal. |
Looking at the internal
knitr:::html_vignette
it looks like*_vignette
functions are just a wrapper over html document function.Could we have such function added to
markdown
package? and exported? @yihuiThe aim is to use it in vignettes, so to specify engine as
knitr::knitr
, which then usesmarkdown
(hopefully supportingtoc: true
,number_sections: true
?).The function will allow to reduce dependencies from 30 (or 27 because 3 deps are common with
knitr
)to only 2 (or 1 because 1 dep is common with
knitr
)The text was updated successfully, but these errors were encountered: