-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chrome_print URL regeneration #113
Comments
The only goal of #97 was to enhance For instance, one can use this argument in the console pagedown::chrome_print('https://pagedown.rbind.io/', async = TRUE)
#> <Promise [pending]> When The |
I see what you mean, the code above is specific to the example you posted in the previous issue and pull. I understand, and 114 is the right place to discuss it. I understand the purpose of I believe my use-case is just a little different from your previous example, so it might not be as immediate for me: in your case, you want a PDF version of the current app, widgets/controls and all; in my case, I believe that for each Thanks for the discussion, I don't know that I need to keep this issue open, feel free to close if you think it best. |
Migrated from #97.
I'm sorry for hijacked a completed PR @cderv, I was wondering if the PR was either prematurely merged or something else. I notice a difference in the app's URL (and
#
handling) when an app is loaded from the dashboard (still with the right nav-bar with info/access/runtime/.../logs) and loaded full-browser ("normal" users). I wonder if there's a way for the app to know this in real-time so that the URL can be generated correctly. Perhapssession$request$SCRIPT_NAME
?Below is the original comment, thanks.
As an aside, @RLesur, the sample app is ignoring leading path information (such as on a reverse-proxied RStudio Connect (RSC)). Something like:
is a start. Unfortunately, in an RSC app it produces the first, when it should be producing the second:
I don't have a fully-functioning RSC-version yet. (I've been hijacking this PR and #91 to learn more about pagedown in shiny. Thanks!)
The text was updated successfully, but these errors were encountered: