renv_pak_restore tries to move packages to cache instead of installing from cache

[Fuco1]

I think the following code in pak.R function renv_pak_restore

  # attempt to link packages that have cache entries
  if (renv_cache_config_enabled(project = project)) {
    linked <- map_lgl(records, renv_cache_synchronize)
    records <- records[!linked]
  }

links the installed packages into the cache, not the other way around. Looking at renv::install, it calls

 if (cacheable) {

    # check for cache entry and install if there
    path <- renv_cache_find(record)
    if (renv_cache_package_validate(path))
      return(renv_install_package_cache(record, path, linker))

  }

to install packages from cache.

But the code in renv_pak_restore is called before

# perform installation
  pak$pkg_install(remotes)

so in effect there is nothing for it to sync into the cache?

[hadley]

Part of #1210