Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix error when running under radian #1670

Merged
merged 4 commits into from
Sep 17, 2024
Merged

Fix error when running under radian #1670

merged 4 commits into from
Sep 17, 2024

Conversation

t-kalinowski
Copy link
Member

closes #1668

@randy3k
Copy link
Contributor

randy3k commented Sep 16, 2024

Tested on macOS, works perfectly. Thank you for the quick fix.
Though I wonder why you want to skip windows. radian was working perfectly fine on windows too.

@t-kalinowski
Copy link
Member Author

Thanks! I replied about the Windows question here: 817c988#r146786827

@t-kalinowski
Copy link
Member Author

Thank you, @randy3k!

I believe I understand what was happening and have pushed another fix. With this branch, radian should now work on all platforms again, including Windows. Would you be able to run Radian CI tests against this branch to confirm?

@randy3k
Copy link
Contributor

randy3k commented Sep 16, 2024

Perfect, all tests pass randy3k/radian#490.
Thank you for the quick response.

@t-kalinowski t-kalinowski merged commit ccbcf90 into main Sep 17, 2024
16 checks passed
@t-kalinowski t-kalinowski deleted the fix/radian branch September 17, 2024 00:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

reticulate 1.39 breaks embedding R in python environment.
2 participants
@t-kalinowski @randy3k