Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SidebarMenu: badge does not line up in Firefox #240

Open
shosaco opened this issue Aug 29, 2017 · 3 comments
Open

SidebarMenu: badge does not line up in Firefox #240

shosaco opened this issue Aug 29, 2017 · 3 comments
Labels

Comments

@shosaco
Copy link

shosaco commented Aug 29, 2017

When using a badge, it does not line up in the current devtools version:

shinyApp(
  ui = dashboardPage(
    dashboardHeader(),
    dashboardSidebar(sidebarMenu(menuItem("Widgets", badgeLabel = "new", badgeColor = "green"))),
    dashboardBody()
  ),
  server = function(input, output) { }
)

image

@bborgesr
Copy link
Contributor

bborgesr commented Sep 8, 2017

It works fine for me, both with the CRAN version and the development version:

screen shot 2017-09-08 at 4 22 12 am

If in a clean session, after a fresh install, you still see the same problem, can you give me the output you get once you enter devtools::session_info()?

@shosaco
Copy link
Author

shosaco commented Sep 8, 2017

Just noticed it works fine in RStudio Browser, Chrome and IE, Firefox is the only case where it does not line up.

image

@shosaco shosaco changed the title SidebarMenu: badge does not line up SidebarMenu: badge does not line up in Firefox Sep 8, 2017
@bborgesr
Copy link
Contributor

bborgesr commented Sep 8, 2017

I can confirm that this is indeed an issue in Firefox. I'll look into it the next time that I'm working on this package. If this is critical for your app, you can tweak the CSS to make it line up (through trial and error and using your browser's developer tools). Thanks for the report!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants