Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(PanelGroup): missing border for nested panels #2142

Merged
merged 1 commit into from
Nov 19, 2021

Conversation

SevenOutman
Copy link
Member

@SevenOutman SevenOutman commented Nov 19, 2021

Before
image

After
image

@vercel
Copy link

vercel bot commented Nov 19, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployments, click below or on the icon next to each commit.

rsuite-v4 – ./docs

🔍 Inspect: https://vercel.com/rsuite/rsuite-v4/FsEFax5DBKYGb7o2EnJSxXkknqoW
✅ Preview: Canceled

rsuite – ./

🔍 Inspect: https://vercel.com/rsuite/rsuite/CJv6YywsQzVnf1nHmBN9XxfPp9vH
✅ Preview: https://rsuite-git-fix-nested-panel-missing-border-rsuite.vercel.app

rsuite-nextjs – ./docs

🔍 Inspect: https://vercel.com/rsuite/rsuite-nextjs/5Z8igLHEHw5a3n3DmRziqGwEAT7C
✅ Preview: https://rsuite-nextjs-git-fix-nested-panel-missing-border-rsuite.vercel.app

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 9394d33:

Sandbox Source
rsuite-tp-ci Configuration

@codecov
Copy link

codecov bot commented Nov 19, 2021

Codecov Report

Merging #2142 (9394d33) into main (57ce5b0) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2142   +/-   ##
=======================================
  Coverage   85.37%   85.37%           
=======================================
  Files         267      267           
  Lines        8401     8401           
  Branches     2286     2286           
=======================================
  Hits         7172     7172           
  Misses        690      690           
  Partials      539      539           
Flag Coverage Δ
ChromeCi 85.34% <ø> (ø)
Firefox 85.35% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 57ce5b0...9394d33. Read the comment docs.

@SevenOutman SevenOutman requested a review from simonguo November 19, 2021 07:13
@SevenOutman SevenOutman merged commit 225821f into main Nov 19, 2021
@SevenOutman SevenOutman deleted the fix/nested-panel-missing-border branch November 19, 2021 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants