fix(CheckTreePicker): fix duplicated key when data changed (#2486) #2500
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit acec9ce:
|
Codecov Report
@@ Coverage Diff @@
## main #2500 +/- ##
==========================================
+ Coverage 85.34% 85.35% +0.01%
==========================================
Files 291 292 +1
Lines 9014 9023 +9
Branches 2527 2529 +2
==========================================
+ Hits 7693 7702 +9
Misses 693 693
Partials 628 628
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
superman66
force-pushed
the
fix/check-tree-picker
branch
from
24360d2 to
46f8f32
Compare
SevenOutman
requested changes
May 24, 2022
SevenOutman
requested changes
May 25, 2022
SevenOutman
approved these changes
May 26, 2022
myNameIsDu
pushed a commit
to myNameIsDu/rsuite
that referenced
this pull request
Oct 12, 2022
…) (rsuite#2500) * fix(CheckTreePicker): fix duplicated key when data changed (rsuite#2486) * test(CheckTreePicker): use rerender to update props * test(CheckTreePicker): replace with testing-library
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When node in data changes position, it's equivalent to changing the data. And selected this node again. Will getting duplicated key error in selected list.
Fix #2486