Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Form): make FormInstance methods non-nullable #2521

Merged
merged 2 commits into from
Jun 2, 2022

Conversation

SevenOutman
Copy link
Member

Fix #2515

@vercel
Copy link

vercel bot commented Jun 2, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
rsuite-nextjs ✅ Ready (Inspect) Visit Preview Jun 2, 2022 at 7:20AM (UTC)
1 Ignored Deployment
Name Status Preview Updated
rsuite-v4 ⬜️ Ignored (Inspect) Jun 2, 2022 at 7:20AM (UTC)

@SevenOutman SevenOutman requested a review from simonguo June 2, 2022 07:18
@codesandbox-ci
Copy link

codesandbox-ci bot commented Jun 2, 2022

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit a0c2892:

Sandbox Source
rsuite-tp-ci Configuration

@codecov
Copy link

codecov bot commented Jun 2, 2022

Codecov Report

Merging #2521 (a0c2892) into main (b480ab4) will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #2521      +/-   ##
==========================================
+ Coverage   85.28%   85.30%   +0.02%     
==========================================
  Files         292      292              
  Lines        9063     9063              
  Branches     2545     2545              
==========================================
+ Hits         7729     7731       +2     
+ Misses        700      699       -1     
+ Partials      634      633       -1     
Flag Coverage Δ
ChromeCi 85.28% <100.00%> (ø)
Firefox 85.28% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/Form/Form.tsx 88.42% <100.00%> (ø)
src/utils/useRootClose.ts 84.00% <0.00%> (+8.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b480ab4...a0c2892. Read the comment docs.

@SevenOutman SevenOutman merged commit 225af8a into main Jun 2, 2022
@SevenOutman SevenOutman deleted the SevenOutman/issue2515 branch June 2, 2022 08:37
myNameIsDu pushed a commit to myNameIsDu/rsuite that referenced this pull request Oct 12, 2022
* fix(Form): make FormInstance methods non-nullable

* feat: export FormInstance type
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Typing problems in form ref
2 participants