-
-
Notifications
You must be signed in to change notification settings - Fork 941
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(Stack): filter children that should not be rendered #2732
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 01a7b11:
|
Codecov ReportBase: 85.46% // Head: 85.46% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #2732 +/- ##
=======================================
Coverage 85.46% 85.46%
=======================================
Files 297 297
Lines 9117 9118 +1
Branches 2580 2580
=======================================
+ Hits 7792 7793 +1
Misses 693 693
Partials 632 632
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
e1cb308
to
01a7b11
Compare
* fix(Stack): remove empty child * test(Stack): add empty child case * fix(Stack): fix test case * fix(Stack): fix children count * test(Stack): change test assertion
CHANGES
use
React.Children.toArray
remove empty children likenull
,undefined
&boolean
value.ISSUE
close #2731