Skip to content

Commit 13a0b60

Browse files
committed
make deserialize/serialize of config consistent; optimize if-else statement for getStoredState.js & createPersistoid.js
1 parent a94f291 commit 13a0b60

File tree

3 files changed

+13
-5
lines changed

3 files changed

+13
-5
lines changed

src/createPersistoid.js

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,9 +16,13 @@ export default function createPersistoid(config: PersistConfig): Persistoid {
1616
config.keyPrefix !== undefined ? config.keyPrefix : KEY_PREFIX
1717
}${config.key}`
1818
const storage = config.storage
19-
let serialize = config.serialize === false ? x => x : defaultSerialize
20-
if (typeof config.serialize === 'function') {
19+
let serialize
20+
if (!config.serialize) {
21+
serialize = defaultSerialize
22+
} else if (typeof config.serialize === 'function') {
2123
serialize = config.serialize
24+
} else {
25+
serialize = x => x
2226
}
2327
const writeFailHandler = config.writeFailHandler || null
2428

src/getStoredState.js

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,9 +13,13 @@ export default function getStoredState(
1313
}${config.key}`
1414
const storage = config.storage
1515
const debug = config.debug
16-
let deserialize = config.serialize === false ? x => x : defaultDeserialize
17-
if (typeof config.deserialize === 'function') {
16+
let deserialize
17+
if (!config.deserialize) {
18+
deserialize = defaultDeserialize
19+
} else if (typeof config.deserialize === 'function') {
1820
deserialize = config.deserialize
21+
} else {
22+
deserialize = x => x
1923
}
2024
return storage.getItem(storageKey).then(serialized => {
2125
if (!serialized) return undefined

src/types.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ export type PersistConfig = {
2424
getStoredState?: PersistConfig => Promise<PersistedState>, // used for migrations
2525
debug?: boolean,
2626
serialize?: boolean | Function,
27-
deserialize?: Function | null,
27+
deserialize?: boolean | Function,
2828
timeout?: number,
2929
writeFailHandler?: Function,
3030
}

0 commit comments

Comments
 (0)