Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

persistReducer creates a reducer that will create a new state on each action #622

Closed
stropitek opened this issue Dec 14, 2017 · 3 comments · Fixed by #689
Closed

persistReducer creates a reducer that will create a new state on each action #622

stropitek opened this issue Dec 14, 2017 · 3 comments · Fixed by #689

Comments

@stropitek
Copy link

stropitek commented Dec 14, 2017

First, thank you for the library!

I noticed that on every action, the new state returned by a persisted reducer changes. Even if state has not changed and the object returned by the base reducer is the same. This is quiet unexpected. Is it intended?

...baseReducer(restState, action),

@Keethanjan
Copy link

Currently we are also having the same issues. Due to this reselect is not memorizing the values.
Could you guys answer if this is intended?

Thanks in advance!

@rt2zz
Copy link
Owner

rt2zz commented Feb 1, 2018

sorry this took a while, definitely an important fix.

proposed solution here: #689

feedback appreciated, I will get this into a beta release shortly

@rt2zz rt2zz closed this as completed in #689 Feb 1, 2018
@hockeylagu
Copy link

#747

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants