Add an option to delay the automatic persistence. #986
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@aguynamedben Can we get this merged please? There are no compatibility issues with previous version. |
Closed
|
going to include this in the forthcoming rc |
|
|
|
@leoek, thanks for the update! Looking forward! |
|
@alex-gokkun Thanks for the heads up. I'll provide them in a follow up. |
|
@leoek, thank you! |
|
Just starting to dive deeper into this lib. Awesome work so far. Thanks for the contribution! |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are use cases, where the persistence cannot be started immediately. For example, if there is a passphrase from the user needed, to complete the initialization of the storage.
This PR adds the option
manualPersist, which if set to true, avoids that the persistence is started automatically.persistor.persist()can be called later, to start persistence. For example if the initialization of the storage is completed.The option is optional, therefore there wont be any compatibility issues, with previous versions. If the options object or the property is not set, everything will behave as before.
This fixes #952